http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11960 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26456|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26459&action=edit Bug 11960: GetMemberDetails is unnecessarily called in CanBookBeRenewed C4::Circulation::CanBookBeRenewed calls C4::Members::GetMemberDetails to retrieve categorycode and branchcode. - categorycode is used to retrieve the issuing rule - the borrower information is passed to C4::Circulation::_GetCircControlBranch. Which only uses the branchcode parameter. GetMemberDetails does a lot of useless calls/queries (patronflags, account, etc.). This call could be replaced with a call to C4::Members::GetMember. Note: I presented this small optimisation during a quick introduction to NYTProf (hackfest 14 in Marseille). Test plan: - launch member unit tests - check the code -- You are receiving this mail because: You are watching all bug changes.