https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34776 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Couldnt finish here, but a few questions: This if seems unneeded :) if ( $op eq 'add_form' ) { C4::Form::MessagingPreferences::restore_form_values( $input, $template ); } else { C4::Form::MessagingPreferences::restore_form_values( $input, $template ); } + my @transport_types = $input->multi_param($message_attribute_id); + foreach my $transport_type (@transport_types) { + $option->{ 'transports_' . $transport_type } = 1; + } What is done here exactly? Not all values are transport types, right ? A new routine in a module requires a unit test. Could you add one? -- You are receiving this mail because: You are watching all bug changes.