https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41315 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passing QA. Having the impression that the changes around patron-homebranch did not make this code easier to maintain etc.. Just a minor observation. This looks dubious (L516): if ($owning_library) { $item_sql .= ' AND items.homebranch = ? ' unless ($patron_homelibrary); If you set item-homebranch, why test if it is patron-homebranch ? -- You are receiving this mail because: You are watching all bug changes.