https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #24)
As for the gaps situation, this patch only covers the 'singular' use case, so that's a different bug. I narrowed the implementation to what I needed for bug 29275, and am willing to work on the plural embeds once we agree on the implementation. I also think we shouldn't leave gaps.
Actually, we do cover the plural somewhat here.. As we call `to_api` from within `_handle_to_api_child` and we're passing around the `user` now and using `is_accessible` we will end up null gaps in our plural embeds. I actually think that's correct as it stands.. we're sending back a null for the singular case and we're including the null in the count variable of the embed.. so gaps are meaningful. I however have no idea if our client-side code knows how to handle such situations as yet. -- You are receiving this mail because: You are watching all bug changes.