http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2809 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-02 08:34:59 UTC --- GBSD#4 comments including some QA: First, this patch does not have a test plan; it is very hard to know if it actually makes a difference in current Koha. Second, the patch comments the indexes_set++ for indexes yr and acqdate; this should not be done! It actually make some searches resultless. Test something like: yourserver/cgi-bin/koha/opac-search.pl?idx=yr&q=2005 Without the patch, it could have results. Note however that this URL is not constructed as such by advanced search: advanced search adds a yr-limit string. Third, the test "if ($this_limit){" should be extended to not only test for empty string but also spaces. If an empty &limit= should be appended after a search URL, it does not even hit that test. If I append &limit=%20, it makes the search crash. This test could eliminate that (rather fictitious) situation. My preliminary conclusion: this patch is actually not needed anymore in current Koha and in its current condition it fails QA. I would suggest to close this report. If I overlook something, please provide examples for current master to demonstrate it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.