http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2419 Summary: Adding a Vendor crashes Koha (error in updateseller.pl file) Product: Koha Version: HEAD Platform: PC OS/Version: Linux - Suse Status: NEW Severity: normal Priority: P3 Component: Acquisitions AssignedTo: rch@liblime.com ReportedBy: ricmarques@spamcop.net QAContact: koha-bugs@lists.koha.org CC: galen.charlton@liblime.com I'm using openSUSE 11.0 (that runs Perl 5.10.0). I am using the latest Koha "snapshot" development version from git available today (29-Jul-2008). My Koha DB (database) version number is 3.00.00.103 The problem is that, when adding a Vendor, after clicking on the "Save" button, I get the following error message in the browser: Undefined subroutine &main::AddBookseller called at /usr/share/koha/intranet/cgi-bin/acqui/updatesupplier.pl line 92. STEPS TO REPRODUCE: 1 - Go to the "Intranet" home page (log in with some "superlibrarian" user): http://192.168.0.1:8080/ 2 - Go to "Acquisitions" section: http://192.168.0.1:8080/cgi-bin/koha/acqui/acqui-home.pl 3 - (I see a strange highlighted message under "Start,receive or modify any order" that says "You must define a budget in Administration" - strange because I have already created a Fund and a Budget) 4 - Click on the "+ New Vendor" button in that page: http://192.168.0.1:8080/cgi-bin/koha/acqui/supplier.pl?op=enter 5 - Fill just the "Company Name" (that is the only mandatory field of the form) with some thing - e.g "Fictional Publisher" (without the quotes) and click on the "Save" button at the bottom. After doing this, I get the following error in updatesupplier.pl: http://192.168.0.1:8080/cgi-bin/koha/acqui/updatesupplier.pl ____________________ Koha error The following fatal error has occurred: Undefined subroutine &main::AddBookseller called at /usr/share/koha/intranet/cgi-bin/acqui/updatesupplier.pl line 92. ____________________ The only entries in /var/log/koha-error.log for today are several lines with that same message: ____________________ [Wed Jul 30 01:03:19 2008] [error] [client 192.168.0.2] [Wed Jul 30 01:03:19 2008] updatesupplier.pl: Undefined subroutine &main::AddBookseller called at /usr/share/koha/intranet/cgi-bin/acqui/updatesupplier.pl line 92., referer: http://192.168.0.1:8080/cgi-bin/koha/acqui/supplier.pl?op=enter ____________________ PROPOSED SOLUTION: Change line 92 of "updatesupplier.pl" FROM: ____________________ $data{id}=AddBookseller(\%data); ____________________ TO: ____________________ $data{id}=C4::Bookseller::AddBookseller(\%data); ____________________ ... and, while we're at it, change line 90 of the same file FROM: ____________________ ModBookseller(\%data); ____________________ TO: ____________________ C4::Bookseller::ModBookseller(\%data); ____________________ Doing this seems to have fixed the Bug in my setup. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.