http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. Tompsett from comment #21)
Comment on attachment 40777 [details] [review] Bug 14382: [QA Follow-up] Bad regex alarm
Review of attachment 40777 [details] [review]: -----------------------------------------------------------------
::: reports/guided_reports.pl @@ +754,4 @@
my $quoted = $sql_params[$i]; # if there are special regexp chars, we must \ them $split[$i*2+1] =~ s/(\||\?|\.|\*|\(|\)|\%)/\\$1/g; + if ($split[$i*2+1] =~ /\|date$/) {
While I agree with the escaping (I really should have caught that, DOH!), the $ does not work. Why not leave >>? >'s are not special characters, are they? I was thinking it may be better to put: /\|\s*date\s*>>/
Please explain why the $ should not work. I agree btw that \s* could be put in additionally. But the >> should be removed, because of the split /<<|>>/,$sql. When I tested this, it worked. -- You are receiving this mail because: You are watching all bug changes.