https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40853 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Minor points here: [FAIL] installer/data/mysql/atomicupdate/bug_40853.pl FAIL forbidden_patterns forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 13) forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 13) +('ElasticsearchBoostFieldMatchAmount', '1', NULL, 'A numeric rank for the boost of field matches', 'Integer'), Shouldnt that be equal to 0 as in the dbrev? -- You are receiving this mail because: You are watching all bug changes.