http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #17)
Patches rebased (conflict with bug 13242).
I removed the useless processing (I don't remember why I parse the string...) and an eval.
Please obsolete my patch if you think the first patch is better alone.
I like your approach. You eval the datetime, and if it fails you just assume is a date without time, thus a floating tz is used instead. It might fail in some situations (date is invalid no matter the tz). Will test it and find a border situation to write a regression test for. -- You are receiving this mail because: You are watching all bug changes.