https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19475 --- Comment #14 from Emmi Takkinen <emmi.takkinen@outlook.com> --- (In reply to Jonathan Druart from comment #13)
2 things about the tests: * Why do you use raw SQL queries to retrieve holidays, who not using existing subroutines? Simply because calendars subroutines hide this bug. If you look at the descriptions for them in C4::Calendar.pm it is stated that they return a hash reference which use holidays as keys. So all duplicate values are (naturally) ignored. I tried to use them but in the end only solution I could come up with was those queries :/
* It's better to flush the cache at the end of the tests, holidays are set in cache. It would make sense to have a flush at the end of the test file. You're right, missed that one. I'll add it at some point.
-- You are receiving this mail because: You are watching all bug changes.