http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11804 Bug ID: 11804 Summary: there should not be both a circ-menu.tt and a circ-menu.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org koha/koha-tmpl/intranet-tmpl/prog/en/includes/ contains both a circ-menu.tt and a circ-menu.inc. circ-menu.tt contains the following comment: [%# duplicates circ-menu.inc but assumes all borrower attributes are in a borrower variable rather than in the global namespace %] circ-menu.tt is used only by the following templates: members/pay.tt members/paycollect.tt This is a blatant violation of the DRY principle, and some inconsistencies have appeared over the years: * the purchase suggestions tab doesn't show up when using the fine payment page * the logic for displaying the notices tab differs The duplication should be removed, perhaps as part of a larger project to make all of the patron and circulation pages use the same routine to grab information about the current patron. -- You are receiving this mail because: You are watching all bug changes.