https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Needs Signoff |Failed QA --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- Hi Ere, it looks almost good just few thinks: Holds to pull does not show data in table Hold ratios does not work (see bellow) Note, that changes in Koha::Schema files should be in its own commit - to avoid conflicts on hash Also this is report from qa tools: FAIL circ/reserveratios.pl FAIL valid "my" variable @reservedata masks earlier declaration in same scope Global symbol "$data" requires explicit package name (did you forget to declare "my $data"?) "my" variable $rd masks earlier declaration in same statement circ/reserveratios.pl has too many errors. Global symbol "$thisratio" requires explicit package name (did you forget to declare "my $thisratio"?) syntax error FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL forbidden patterns forbidden pattern: tab char (line 156) FAIL opac/opac-showreviews.pl FAIL forbidden patterns forbidden pattern: tab char (line 100) forbidden pattern: tab char (line 101) forbidden pattern: tab char (line 99) forbidden pattern: tab char (line 102) -- You are receiving this mail because: You are watching all bug changes.