https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40300 --- Comment #11 from Alexander Wagner <alexander.wagner@desy.de> --- (In reply to Bernard from comment #7)
(In reply to Alexander Wagner from comment #3)
Probably a bit philosophical: While I am personally all for removing punctuation from records and adding them automatically, I do wonder if in your case Koha is not entering a strange mixture. IMHO
- if a punctuation _is there_ the logic should be to keep and use it. - if no punctuation is there it should add it.
[...]
Interesting. I'm all for anything that can make this simpler and I like your idea of a separate punctuation.pm. I would be reluctant to have to rely on the LDR position 18 value as experience shows this may be set to "a" but that not be the reality.
Hm, but we agree that the records you have in mind are "broken" wrt the idea of Marc in this regard. Shouldn't one fix the broken record then (IOW fix the leader)? I think in general one will have a mixture of records in any given system over time, those that hold the punctuation and those that don't, right? They may just flood in during cataloguing if you ingest records from various sources. (AFAIK the SRU/Z39.50 importers do _not_ strip or add punctuation, so it depends on the source what you get.)
Perhaps a syspref making it an option?
Uh. This adds another unrelated point to configure what to do with those funny chars and it would apply globally as well. One could head for a switch for - follow the leader - ignore the leader and treat as "records have punctuation" - ignore the leader and treat as "records don't have punctuation" Where in the last case you'd chop everything "just in case". This sounds a bit weird.
I guess the issue is if we currently already use chopPunctuation
I noticed that, indeed. I was wondering all the time if this is not fixing a fix for a fix that might get another layer of plaster as soon as another issue pops up ;) That's the sole reason why I commented on this bug here that I noticed quite a few occurrences of chopping while some fields never see it.
at all in the xslt (we do), it should do it everywhere required.
When I looked at Koha sample records for the test cases to `punctuation.pm` I found, that "strange things happen in cataloguing" that will not allow to add punctuation in _all_ corner cases automatically. Or actually the other way round: it is well possible and following the rules to construct a record that will not allow automatic punctuation. Hence, for those cases it might be necessary to add the punctuation on record level. But to give a proper display in those cases you'd have to leave the punctuation alone. I think this is the reason behind the leader-switch.
Or else not at all.
I tend to believe "not at all" would be the way to go. Or at least if it's done in xslt it should follow the leader and if the display is wrong the offending leader can be fixed easily.
For now, pragmatically, I think I'd rather stick to fixing what we have.
This is also ok with me if Koha thinks this is the way to go. I just see some more issues down the winding road as chopping assumes you can _always_ add the punctuation automatically. (If so, why not strip it entirely on ingest and set the leader properly ;) -- You are receiving this mail because: You are watching all bug changes.