https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631 --- Comment #179 from Casey Conlin - mattermost @Casey246 <casey.conlin@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #176)
This needs work, it's causing the following test failure:
# Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt has 'kohaTable' instances in a <script> tag with Template::Toolkit tags.' # at xt/tt_kohaTable_tidy.t line 58. # got: '1' # expected: '0' # Looks like you failed 3 tests of 886.
I believe because of the following line inside <script> tags: [% IF (saved1) %]
One test was failing for koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt I added a fix for this, but the other two tests that are failing look like they're related to the register.tt and registers.tt files which are not related to the work in the 16631 patch. I can look into fixing these, but I thought it might be cleaner to keep the work to fix those files closer to their patch, and the developer that made the changes might be able to make a more informed fix. If there are other issues related to this patch please let me know. Thank you! From prove -v xt/tt_kohaTable_tidy.tTemplate::Toolkit: not ok 614 - koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt has 'kohaTable' instances in a <script> tag with Template::Toolkit tags. # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt has 'kohaTable' instances in a <script> tag with Template::Toolkit tags.' # at xt/tt_kohaTable_tidy.t line 58. # got: '1' # expected: '0' not ok 615 - koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt has 'kohaTable' instances in a <script> tag with Template::Toolkit tags. # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt has 'kohaTable' instances in a <script> tag with Template::Toolkit tags.' # at xt/tt_kohaTable_tidy.t line 58. # got: '1' # expected: '0' -- You are receiving this mail because: You are watching all bug changes.