https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #25)
So.. I'm mostly OK with these patches.. but I have a related question:
What's the history around the continual regeneration of dbic result classes?
My general understanding of dbic over the past couple of years is that 'dbicdump' is really about allowing a migration path from a non-dbic system to a system with dbic classes. It's a one time thing, and then you should really maintain the classes and instead generate the db changes from them as opposed to the other way around. If we did this, we could happily rename our resultset and result classes and remove some of the code here that requires mapping from ::Object to ::Result classes.
Just something to bare in mind. I could happily write a proof of concept for such a trivial dbic ::Result object example should people be interested in such.
Yes, I think we should move forward too and obsolete kohastructure.sql etc. iirc there were problems with deploying (instead of running kohastructure for a new install), perhaps on some specific systems? Running the sql file probably was considered safer. Furthermore we would need to address how to deploy for existing installs in updatedatabase. -- You are receiving this mail because: You are watching all bug changes.