https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871 --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- My thoughts: 1. C4::Stats in Koha::Item::_add_statistic This is out of scope for bug 19871. The _add_statistic call in Koha::Item is unrelated to the exception translation work — it just happens to be in the same file. Replacing C4::Stats::UpdateStats with Koha::Statistic->new($params)->store is a separate cleanup task. Worth doing, but not in this bug. 2. Util wasn't the best name, but I placed it under Schema as I felt it related directly to DBIC and was clear there.. honestly a bit annoyed that we go PQA after waiting 7 months then within seconds right at the end of a cycle ask for more changes. How about 'Koha::Exceptions::DBIC::Translator'.. but of course changing now will require the bugs on top of this to all be refactored. 3. It's translating exceptions.. so I think Translator makes sense. 4. OK, bad comment, I'll remove it. -- You are receiving this mail because: You are watching all bug changes.