https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29800 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197918&action=edit Bug 29800: (QA follow-up) Coordinate WhenLostUpdateFine with WhenLostForgiveFine Both preferences act on the overdue fine when an item is marked lost: WhenLostUpdateFine recalculates and persists it, WhenLostForgiveFine zeroes it. If both are enabled, we used to compute the updated fine and then immediately wipe it a few lines later in _FixOverduesOnReturn. Make WhenLostForgiveFine take precedence: when it is on, skip the recalculation entirely so we don't do wasted DB writes. Document the precedence in the admin UI text. Test plan: 1 - Define a circ rule with an overdue fine, FinesMode = production. 2 - Check out an item with a due date in the past. 3 - Run fines.pl so an accruing fine exists. 4 - Edit the circ rule to change the fine amount. 5 - Enable WhenLostUpdateFine and WhenLostForgiveFine. 6 - Mark the item lost. 7 - Confirm the fine on the patron is 0 (forgiven), no accounting churn in the intervening step. 8 - Confirm the circulation admin page shows the precedence note on WhenLostUpdateFine. -- You are receiving this mail because: You are watching all bug changes.