https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15886 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48317|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48318&action=edit Bug 15886 - Revise layout and behavior of audio alerts management This patch changes the behavior of the audio alerts management page so that sections of the page are shown or hidden based on what the current task is. Other changes include: - Moving JavaScript to a separate file - Adding a toolbar with a "New alert" button. - Enabling or disabling the "play sound" button based on the value of the sound file field. - Enabling or disabling the "delete" button based on whether there are checkboxes checked. - Switching the patron category administration header search form for the "generic" catalog search one. - Adding "Required" classes to required fields so that the staff client's built-in JS validation library can be used. - Styling the add/edit form in a way which is consistent with other interfaces in Koha. - Removing the invalid "border" attribute from images. - Adding better alt attributes to images. To test, the AudioAlerts system preference must be enabled. Apply the patch and go to Administration -> Audio alerts. - Confirm that the add/edit form is hidden initially. A toolbar with a "New" button should appear with existing audio alerts in a table below. - Confirm that the "New alert" button works: - The table should be hidden and an empty "add" form displayed. - Confirm that an empty form cannot be submitted. - Confirm that typing or selecting a sound enables the "Play sound" button and that it works to play the sound. - Confirm that adding valid data works. - Confirm that clicking the "Cancel" button hides the form and redisplays the table. - Test the "edit" button for an existing sound: - Confirm that the edit form is displayed and populated with the correct data. - Confirm that edits are saved correctly. - When viewing the table of existing alerts, confirm that checking one of the checkboxes "enables" the delete button. - With one or more checkboxes checked, test that clicking the delete button triggers a deletion confirmation. Test both confirm and cancel operations. - With no checkboxes checked, test that clicking the delete button triggers an alert that checkboxes must be checked. - Ponder whether all this is an improvement or not. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.