http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7477 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Assignee|srdjan@catalyst.net.nz |jonathan.druart@biblibre.co | |m --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 8083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8083&action=edit Bug 7477 Followup Fix perlcritic issues QA comment: Hi Srdjan ! Your patch redefine the daysBetween routine: perl -wc C4/Calendar.pm Subroutine daysBetween redefined at C4/Calendar.pm line 663. And does not passed the perlcritic: Subroutine prototypes used at line 663, column 1. See page 194 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 664, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 665, column 30. See page 199 of PBP. (Severity: 5) I submit a new patch to fix these issues. Could you signed off it please ? -- You are receiving this mail because: You are watching all bug changes.