https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30661 --- Comment #30 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #29)
Could you have a look if these failures relate to this change and provide a fix?
prove t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/holds.t .. 1/14 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 610. t/db_dependent/api/v1/holds.t .. 12/14 # Looks like you planned 37 tests but ran 3. t/db_dependent/api/v1/holds.t .. 13/14 # Failed test 'PUT /holds/{hold_id}/pickup_location tests' # at t/db_dependent/api/v1/holds.t line 1470. Can't locate object method "branchcode" via package "euRljh" (perhaps you forgot to load "euRljh"?) at t/db_dependent/api/v1/holds.t line 1377. # Looks like your test exited with 11 just after 13. t/db_dependent/api/v1/holds.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 2/14 subtests
Not related to this, I think. I didn't get that HOLD_CANCELLATION error after I pulled main repo. The subtest "PUT /holds/{hold_id}/pickup_location tests" fails in holds.t There are some interesting branchcode fetching in "PUT /holds/{hold_id}/pickup_location tests" at least: $hold->discard_changes->branchcode->branchcode If those second branchcode values are removed the tests pass in that subtest. -- You are receiving this mail because: You are watching all bug changes.