https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147611|0 |1 is obsolete| | --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 147660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147660&action=edit Bug 32613: Add autocomplete to SQL reports editor This adds auto-complete for the sql reports editor codemirror instance. To prevent a regression in syntax highlighting the overlay mode 'sqlPlaceholders' has been removed and replaced with a highlighting engine that works correctly with the autocomplete engine. Test Plan: 1. Navigate to reports and create a new sql report 2. Write an Sql query and observe that there is no autocomplete options 3. Apply patch 4. Write a new Sql query and observe that there are now auto-complete options that can be navigated through with the arrow keys and accepted with either tab or the enter keys. 5. Ensure that items bounded in << >> or [[ ]] are still syntax highlighted post-patch additionally added helpful note under codemirror instance to assist with codemirror autocompletion and removed prohibited words from sql language (by moving from sql.min.js to sql.js) -- You are receiving this mail because: You are watching all bug changes.