https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40869 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- (In reply to Katrin Fischer from comment #4)
Reading through the test plan I wonder if this is the right solution or not.
I can see the merit for values like homebranch/holdingbranch. We usually use a "Default" with the branchcode for these, but don't set the fields to mandatory.
My first reaction would be, that we should display an error message somewhere if a mandatory field is hidden from a form on saving. I believe that would match the behavior we see in other places like patron self registration.
If we move on with this:
1) QA tests fail (tidy) 2) Unit tests were updated for the name change, but I feel there should be additional tests for the difference between mandatory and optional hidden fields as well (up to QA)
(setting failed QA to raise attention of the developer and for 1) and 2).
Thanks for the feedback. Regarding tidy issues I can't manage to reproduce that. I've run the tidy script on affected files and they remain the same for me. I added a test for a hidden and required subfield. I'm not really able to change the behavior to display an error instead, as the this is what we need, and if the behavior changed we would probably need a custom patch to change it back to this one. I'm not sure, but since the branchcode is a hidden field for us, I'm not even sure a default value would solve the problem, but I'm not sure regarding that. -- You are receiving this mail because: You are watching all bug changes.