https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38291 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #65 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all: 1) All 7 boolean filter query parameters on GET /library_groups (hide_patron_info, is_opac_search_group, is_staff_search_group, is_local_hold_group, is_local_float_group, limit_item_editing, limit_report_access) are typed integer, but the endpoint returns those attributes as booleans. A client that filters with the value it reads back gets a 400. Changing the parameter type after release would be an API change. 2) In api/v1/swagger/definitions/library_group.yaml, hide_patron_info is not listed under 'required', but the other 6 boolean attributes are. These 7 columns are all NOT NULL. To reproduce 1: 1) Apply the patches, then run 'yarn api:bundle' and 'koha-plack --restart kohadev' 2) Log in to the staff interface as koha and go to http://localhost:8081/cgi-bin/koha/admin/library_groups.pl 3) Click the 'New group' button, enter 'Test group' as the title, tick 'Is local hold group' and click 'Save' 4) In the same browser, go to http://localhost:8081/api/v1/library_groups 5) Confirm 'Test group' is returned with "is_local_hold_group": true 6) Go to http://localhost:8081/api/v1/library_groups?is_local_hold_group=true 7) Confirm you get a 400 'Expected integer' 8) Go to http://localhost:8081/api/v1/library_groups?is_local_hold_group=1 9) Confirm you get a 200 and 'Test group' is returned Non-blockers: - t/db_dependent/api/v1/library_groups.t imports List::Util qw(min), but it is never used. - created_on and updated_on have no format: date-time, and updated_on allows null although the column is NOT NULL. -- You are receiving this mail because: You are watching all bug changes.