https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43380 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 204173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204173&action=edit Bug 43380: Koha will generate spurious print notices if itiva is enabled and a patron has only selected phone notices If a patron only has itiva notices enabled ( and possibly sometimes with other transports enabled, depending on sorting ), Koha will always generate a print notice for them. The itiva check is always true if TalkingTechItivaPhoneNotification is enabled, so itiva falls into the same branch as a transport that can't be delivered and a print notice is sent. The itiva notice itself is generated by TalkingTech_itiva_outbound.pl, so there is nothing to queue here and no reason to fall back to print. This patch skips itiva when TalkingTech_itiva_outbound.pl will handle the notice, and falls back to print when it won't, that is when TalkingTechItivaPhoneNotification is turned off or the patron has no phone number for itiva to call. Before this patch that second case queued an itiva notice that nothing would ever send. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Set TalkingTechItivaPhoneNotification to "Enable" 4) Find a patron with a phone number set 5) Set their "Hold filled" messaging preference to phone only 6) Place a hold for them and check the item in to fill the hold 7) Note there is no print notice in their notices tab 8) Clear the patron's phone number, repeat steps 5 and 6 9) Note the print notice is sent this time 10) Set TalkingTechItivaPhoneNotification to "Disable", restore the phone number, repeat steps 5 and 6 11) Note the print notice is sent this time as well! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.