https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #24 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens (kidclamp) from comment #15)
I am not against the concept of auto-escaping the question mark, however, I do think it needs to be controlled by a syspref. Possibly with different options for staff and opac.
Agreed. When we're using the Advanced Search, I'd say we should auto-escape all reserved characters, since it's a structured search. Since we (rightly or wrongly) allow complex queries in the regular "Simple" Search, we're caught in a bit of a tough place. We're giving users the power to write complex queries... but we can't trust them to escape reserved characters either. It's a bit... absurd really. However, for many years, we've had this absurd approach, so for backwards compatibility I think we need to keep it going.
The code and the preference description also need to be clear about what they are doing - silently escaping '?' in the code that handles regex searching is confusing
Agreed. The splinter review looks identical at a glance. If I recall correctly, you can split regex across newlines. Alternatively, we might be able to build it from a series of strings. The current code isn't readable/maintainable. -- You are receiving this mail because: You are watching all bug changes.