https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #3)
(In reply to Jonathan Druart from comment #0)
It won't be a big deal to hit the DBMS to get a valid letter when needed.
Hm. Not sure. getletter is called by GetPreparedLetter, SendCirculationAlert, etc. In loops ?
-# FIXME: using our here means that a Plack server will need to be -# restarted fairly regularly when working with this routine. -# A better option would be to use Koha::Cache and use a cache -# that actually works in a persistent environment, but as a -# short-term fix, our will work.
Why not use this opportunity to add caching?
Because I have not found anywhere it's called many times. As I wrote previously, I am not sure it'd be interesting to cache it, but I may be wrong. If we decide to cache it, we need to make sure the values in cache are deleted when letters are updated/deleted. Anyway it will be a much bigger patch and more an enhancement than a bugfix. -- You are receiving this mail because: You are watching all bug changes.