http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #4)
Hey Julian, I am not sure about passing QA on this patch. You only actually do some trivial tests for IsOverDriveEnabled. The real stuff with requests, UserAgent etc. (probably mocking OverDrive behavior somehow) is not there.
While I agree, I say any coverage is better than no coverage! This won't stop additional tests from being added later. -- You are receiving this mail because: You are watching all bug changes.