https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #98 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209758&action=edit Bug 42383: (QA follow-up) Address check-in page QA findings This patch addresses the check-in page findings from QA (comments 9 and 10), using the API changes from the previous patch: - Sidebar: checkin.tt used the CircSidebar preference, removed by bug 42344, so the circulation sidebar never showed. - Notes column: read the API keys (staff_notes, public_notes, internal_notes) so patron and item notes are displayed. - Patron column: link the patron and show the checkouts count (checkout.patron.checkouts+count). Anonymized checkouts (privacy "Never") no longer show the AnonymousPatron or a checkin slip button. - Print checkin slip opens members/printslip.pl?print=checkinslip. - Book drop mode shows the effective checkin date. - HoldsAutoFill: auto-filled holds don't open the hold modal; a "Hold filled for" box with a Print button is shown, and the slip is printed when HoldsAutoFillPrintSlip is set. - AutomaticConfirmTransfer: the transfer modal no longer confirms itself after a second. As on the legacy page, a non-blocking transfer is confirmed when staff move on (scan the next item). - Hold cancellation: the reason is now sent (wrong authorised value key) together with "Forgive fees for manually expired holds". - "Ignore" on hold, recall and claim modals keeps the row as checked in instead of marking it "Not checked in". - "No, don't transfer" clears the transfer from the row. - Hold modal: "Transfer to" / "Confirm hold and transfer" for holds at another library, and "Hold found (item is already waiting)". - Bundles: the verification table shows title and author, all scanned barcodes are sent (unexpected items are removed from their bundle), missing and unexpected items are reported, "Remove from bundle" works and links to the host record. - Messages: no "Already returned" badge on every return, a single lost item fee outcome (as the legacy IF/ELSIF), not for loan and shelving location changes show old and new values, the checkout note is shown on every return with a formatted date, and an unknown barcode shows "No item with barcode: X". - Values interpolated into the message boxes are HTML-escaped. Test plan: 1. Apply this patch and rebuild: $ ktd --shell k$ yarn js:build k$ restart_all 2. Go to Circulation -> Check in and repeat the scenarios from the QA comments 9 and 10, comparing with the legacy page on main => SUCCESS: Behaviour matches the legacy page 3. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.