https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #261 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Initial QA feedback: 1) The types:check script fails: Property 'maxPeriod' does not exist on type '{ leadDays: number; trailDays: number; }' 2) lint fails: biblio is defined twice in api-client.js - lines 190 and 192 3) The calendar can show booked days as free. Steps to reproduce - In circ rules, set issuelength to a small value (e.g. 3) with no renewals allowed - On a record with one bookable item, create a booking late in the second month. On the day of testing (28/10), the calendar shows me October and November side by side and I booked in for the 25-27th November. - Open the modal again once the booking is placed and use the same patron and library to display the calendar. - Ensure that the left hand month displayed is the current month - 25-27th should have displayed as unavailable but instead shows as available - Navigating forwards a month correctly shows those dates as unavailable - Navigating back to the current month and placing the booking results in a 409 conflict error 4) Booking period boundary is inconsistent - looks like there are inconsistent rules for calculating the booking period? - Using the same settings as above, open the modal and enable the calendar - Pick a start date with no bookings, checkouts or holidays around it and have a look at the end date - If your issue length is 3, you should expect to see 3 days available with the remainder greyed out which is the case but the booking-loan-boundary class is on the first greyed out day and hovering over the first greyed out day gives a conflict error message rather than the "outside booking period" message. 5) Timezone mismatch - dates.js:11-21 builds toDay() as browser-local midnight and today() as library-timezone midnight. predicate.js:171,225 and markers.js:197-209 the compares the two values. If the library and user are in different timezones it will be out by a day 6) Biblio.t - the 'An unrelated unbookable item does not enter the availability pool' can't fail as the $unrelated_item has a booking associated with it already. Should this not be tested against an unbookable item with no booking against it? 7) The OPAC api adapter appears to contain a number of public endpoints that don't exist - are these for use in a follow-up bug or are they legacy code that can be removed? 8) Cypress test findings: - bookingsModalDaetPicker doesn't correctly clean up after itself - libraries and item types aren't deleted - bookingsModalBasic_spec.ts and bookingsModalDatePicker_spec.ts hard-code 2026-06-10 - should follow the pattern in markers_spec.ts Will keep looking but posting this as a start point -- You are receiving this mail because: You are watching all bug changes.