https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=44030 Bug ID: 44030 Summary: FineNoRenewalsBlockAutoRenew set to "allow" no longer allows automatic renewals Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: babarjunaid1122@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- FineNoRenewalsBlockAutoRenew reads "If a patron owes more than the value of FineNoRenewals, [block / allow] their auto-renewals." Set to "allow", automatic renewals of a patron who owes more than FineNoRenewals are still refused. Since bug 23415, CanBookBeRenewed checks FineNoRenewals for every renewal and returns too_much_owing. _CanBookBeAutoRenewed only returns auto_too_much_owing when the preference is "block"; when it is "allow" the automatic renewal goes on to the general check and is refused there anyway. Bug 23415 added an override for self checkout (FineNoRenewalsBlockSelfCheckRenew in sco-main.pl) but not for automatic renewals, so this preference now only changes the error code, never the outcome. To reproduce: 1. FineNoRenewals = 10, FineNoRenewalsBlockAutoRenew = allow. 2. Check out an item as an automatic renewal to a patron with automatic renewals enabled, and make it due for renewal. 3. Give the patron a 15.00 charge. 4. Run misc/cronjobs/automatic_renewals.pl -c: the checkout is not renewed, auto_renew_error = too_much_owing. Reproduced on Koha 26.05.02; the same code is on main. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.