http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #33 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to comment #32)
(In reply to comment #31)
(In reply to comment #27)
QA comment:
* The DB update, you write "ALTER TABLE branches MODIFY branchprinter varchar(20) NULL, ADD FOREIGN KEY (branchprinter) REFERENCES printers (printqueue) ON UPDATE CASCADE" => why not also add ON DELETE SET NULL (on delete cascade would be a strong mistake, you don't want to delete branches just because you deleted a printer !!!) ?
Because we don't want to leave branches without their default printer, so only unused printers can be removed.
So you must catch the error raised by mysql if a printer is deleted and some branches use it.
I can do that if you insist, however current version does not do that, ie does not check anything at all. This is an improvement as is. -- You are receiving this mail because: You are watching all bug changes.