https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42565 --- Comment #5 from Chris Mathevet <chris.mathevet@inLibro.com> --- Created attachment 198876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198876&action=edit Bug 42565: Fix uninitialized value warning in GetIssuingCharges GetIssuingCharges overwrites its initial $charge = 0 with the value of itemtypes.rentalcharge, which is NULL when no rental charge is configured. This causes 'uninitialized value' warnings in every caller that compares $charge > 0 (automatic renewals, SIP checkout/renew, OPAC). The fix normalizes NULL to 0 at the source. All callers already treat the return value as numeric, so this is safe. Also removes a now-redundant $charge && guard in AddIssue that was working around this. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Chris Mathevet <chris.mathevet@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.