https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27014 Bug ID: 27014 Summary: SIP2 cannot find patrons at checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Caused by bug 23403 - when performing a checkin we lookup the SIP patron using the borrowernumber, however, SIP only knows how to find a patron via cardnumber or userid The change on 23403 was to avoid using an 'id' that didn't always exist (as some users don't have a userid or cardnumber When checking in, however, we are not passed a user cardnumber or borrowernumber, so we don't have those on hand to get the patron. from C4/SIP/ILS.pm 245 } elsif ( $circ->ok ) { 246 $circ->patron( $patron = C4::SIP::ILS::Patron->new( $item->{borrowernumber} ) ); 247 delete $item->{borrowernumber}; 248 delete $item->{due_date}; 249 $patron->{items} = [ grep { $_ ne $item_id } @{ $patron->{items} } ]; 250 } else { I actually don't know if the $patron->{items} call is useful, it seems to be updating the patron item cache, but I don't see where we cache it, or read it, we just seem to create new patrons/transactions when needed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.