http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #4)
Jared, thank you for testing.
I confirm the tests pass here :-/ Could you retry with the last patch please? It replaces ok with is. We should have a more readable failure.
I'm still getting failures: jcamins@kohadev:~/kohaclone$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. INSERT INTO borrowers SET borrowers.firstname = ? , borrowers.dateenrolled = ? , borrowers.userid = ? , borrowers.categorycode = ? , borrowers.surname = ? , borrowers.dateexpiry = ? , borrowers.password = ? , borrowers.cardnumber = ? , borrowers.branchcode = ? my firstname,2013-06-07,myfirstname.mysurname,S,my surname,2021-09-07,!,CARDNUMBER42,CPL at /home/jcamins/kohaclone/C4/SQLHelper.pm line 182. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. # Failed test 'CheckReserves Test 1' # at t/db_dependent/Reserves.t line 67. # got: '' # expected: 'Reserved' SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. t/db_dependent/Reserves.t .. 3/4 # Failed test 'CheckReserves Test 2' # at t/db_dependent/Reserves.t line 70. # got: '' # expected: 'Reserved' SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. # Failed test 'CheckReserves Test 3' # at t/db_dependent/Reserves.t line 73. # got: '' # expected: 'Reserved' # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. # Looks like you failed 3 tests of 4. t/db_dependent/Reserves.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/4 subtests Test Summary Report ------------------- t/db_dependent/Reserves.t (Wstat: 768 Tests: 4 Failed: 3) Failed tests: 2-4 Non-zero exit status: 3 Files=1, Tests=4, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.60 cusr 0.06 csys = 0.70 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.