https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37025 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am wondering if we should deviate here from the normal option handling in the other koha scripts. You would expect --generate and --delete here, etc. Might be confusing. Tested koha-api-keys generate 'test' 51 myclone Client ID: c3e0bc35-dbb7-4608-a452-5f2bb850e26b Client Secret: b6999c74-2713-4781-83e2-114fb0525b1b Tested debian/scripts/koha-api-keys delete myclone Client ID to delete: c3e0bc35-dbb7-4608-a452-5f2bb850e26b => How to delete is not clear from the usage statement Usage: debian/scripts/koha-api-keys generate|delete [ description ] [ borrowernumber ] [ instancename ] Also confusing: The bracket pairs seem to suggest that the last 3 parameters are optional. But they are not. Please add separate lines for the generate and delete. Just a question: Should we keep this in shell or move to perl instead? See for instance koha-shell. -- You are receiving this mail because: You are watching all bug changes.