https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #56 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209607&action=edit Bug 42383: (QA follow-up) Set confirmed holds waiting at the check-in desk This patch makes Koha::Checkin->confirm_hold pass the checkin's desk_id to ModReserveAffect, so a hold confirmed (or auto-filled through HoldsAutoFill) on the check-in page is set waiting at the desk the staff member is using, as the legacy circ/returns.pl did. The checkin row already records the desk from the user environment. It addresses point 10 of the QA comment. Test plan: 1. Enable UseCirculationDesks and create a desk for your library 2. Set the desk for your session (Set library and desk) 3. Place an item level hold for a patron, pickup at your library 4. Check the item in on the check-in page and confirm the hold 5. Look at the hold on the record's holds page => FAIL: The waiting hold has no desk 6. Apply this patch and restart plack: $ ktd --shell k$ koha-plack --restart kohadev 7. Repeat 3 to 5 => SUCCESS: The hold is waiting at your desk 8. Run: k$ prove t/db_dependent/Koha/Checkin.t => SUCCESS: Tests pass! 9. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.