https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Martin Renvoize from comment #8)
Current work is distinct from reserves.. although I see many parallels there I felt the 'Queue' nature of reserves vs the 'Booked dates' nature of bookings distinguished them.
Indeed, actually it seems even more relevant compared to the hack we made to bring this functionality to Bokeh! Reserves means it can still be loaned on a conflicting period, or there can be conflicting reserves made from different users. TLDR; I guess you made things in such a way that this situation cannot happen on your branch? I admit i didn't go through all your commits... yet ;)
As for API, the entire thing is designed from the ground up using modern best-practice.. as such, it will all exposed via the RESTful API's.. see the patches on the gitlab branch ;)
Seen that on https://gitlab.com/mrenvoize/Koha/-/commit/c2d3412d390b5a49cc2998ba9c8c25efd... * thumbsup * Thanks for thinking API-wise :) Also I didn't knew about that practice of linking to a git branch instead of uploading the commits... nice :) are we going to use more gitlab workflows like merge request? From my experience, code reviews are quite easy to read and process on gitlab!
This is all very much a work in progress ;)
Nice work already! Wish you can make a demo for next hackfest, hopefully in March? :) -- You are receiving this mail because: You are watching all bug changes.