https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #23)
The classes of the exceptions should not be named with the module they are raised from.
Hmm. Just following what we already did (and approved). Like: package Koha::Patron::Modification; use Koha::Exceptions::Patron::Modification; Koha::Exceptions::Patron::Modification::DuplicateVerificationToken->throw === package Koha::Exceptions::Patron::Modification; 'Koha::Exceptions::Patron::Modification::DuplicateVerificationToken' => { isa => 'Koha::Exceptions::Patron::Modification', description => "The verification token given already exists" }, === Please explain. Should we formulate a coding guideline here? -- You are receiving this mail because: You are watching all bug changes.