https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947 --- Comment #78 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 183568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183568 Bug 36947: (QA follow-up) Fix locale-list to show selected values Review of attachment 183568: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36947&attachment=183568) ----------------------------------------------------------------- ::: admin/preferences.pl @@ +126,4 @@
# Dynamic locale detection for facet sorting using Koha::I18N require Koha::I18N; + my $locales = Koha::I18N::available_locales();
It's worth noting that Koha::I18N::available_locales() returns an arrayref of hashrefs in a format specifically designed for admin/preferences.pl. But then in admin/preferences.pl, we arguably compromise the integrity of that data, because we have to add a "selected" hashref key-value pair to denote the selected preference. It's OK here because we're not re-using $locale in the context of this script. But I thought it was an interesting observation. -- You are receiving this mail because: You are watching all bug changes.