https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42534 Bug ID: 42534 Summary: wrapper-staff-tool-plugin.inc interferes with js and includes in template files Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Wrapper changes in Bug 42163 to support the vue changes made in Bug 41367 means you can't use a separate [% MACRO jsincludes BLOCK %] in plugins. Additionally if you're using any includes (such as datatables.inc) they no longer load because the wrapper [% MACRO jsincludes BLOCK %] overrides any inline [% MACRO jsincludes BLOCK %] You can use [% INCLUDE datatables.inc %] outside the wrapper, but most examples have it inside and I fear plugins using the wrapper will break on an update to 26.05. You can also put your <script> after the wrapper for loading it. We could try and make changes to the plugin structure/wrapper to make this work a little smoother. We could add common includes like datatable, calendar, select2, etc into the wrapper, but that seems like a long term maintenance issue. Another way could be to undo the vue change/figure out another way to load the admin menu or otherwise contain it so it's not overriding in page [% MACRO jsincludes BLOCK %] This would be the least disruptive for existing plugins, so is probably the way to go, but I'm not sure there's a good way to handle this. I'm very open to ideas about how to best handle this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.