https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369 --- Comment #38 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #30)
Hi guys: 1) The commit message says "All hardcoded x-koha-embed headers in client methods are replaced with the declarative embed: [...] parameter", but I only see that happening on item-api-client.js. What am I missing?
Done!
2) It appears vue/fetch/http-client.js is now orphaned, not imported anywhere. Please confirm and clean-up if so.
Corrected! I also had like 3 follow-up commits so I decided to squash most of those. Happy to address any other outstanding issues. To test I did; ```shell $ SYNC_REPO=$PWD ktd --name bug_36369 --proxy up -d $ ktd --name bug_36369 --wait-ready 120 ``` then used `http://bug_36369-intra.localhost` to access the UI and verify things work. In particular I looked at the `ERM` and `Preservation` modules this time. -- You are receiving this mail because: You are watching all bug changes.