https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126228|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127137&action=edit Bug 29223: Use patron's branchcode for digest if not sending digest per branch To test: 1 - Set system preference AutoRenewalNotices to 'according to patron messaging preferences' 2 - Set circ rule for auto renewal - 100 renewals allowed - no renewal before 100 This shoud make a checkout eligible for many auto renewals for testing 3 - Checkout an item to a patron, ensure item is from a different branch than patron 4 - Ensure the patron has an email, and set an email for patron's branch and items branch 5 - Set the patron messaging preferences for auto-renewal to 'email' and 'wants digest' 6 - perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm 7 - Job dies: Can't call method "from_email_address" on an undefined value at /usr/share/koha/bin/cronjobs/automatic_renewals.pl line 286. 8 - Apply patch 9 - Repeat 10 - NO errors 11 - Check patron notices tab, should be a notice enqueued, check DB to see from address is patron's branch 12 - perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch 13 - No errors 14 - Check patron notices tab, should be a notice enqueued, check DB to see from address is item's branch Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.