https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16088 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jacek Ablewicz from comment #9)
Trying to evaluate this patch, but I'm having trouble understanding how it works.
$Koha::CGI::language is a package variable (persistent under plack); if some stript calls Languages::getlanguage() without calling Koha::CGI->new() somewhere earlier, it may pick "outdated" language code (set by some other script which was calling getlanguage() first).
I am feeling a bit silly, this patch did not make any sense, indeed... It seems that I was looking at the performances too much and did not keep in mind that the patch should not be buggy :)
Not sure if the parameters in "use Koha::CGI qw('-no_undef_params' -utf8 )" will get propagated from catalogue/search.pl to Koha::CGI somehow, there is no "use CGI qw( -utf8 );" in the Koha/CGI.pm, there is only commented out "# use base CGI;" (?).
BTW, I wonder why there is "use CGI" instead of "use CGI (-uft8)" in C4::Languages, looks like some kind of exception or omission - is there a correlation with Bug 13815? Can't find an explanation in Bug 13815 why exactly plack was losing that uft8 flag in the 1st place..
I guess we should add the flag to C4::Languages. I do not remember why the flag is getting lost, but it is :) -- You are receiving this mail because: You are watching all bug changes.