https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16869 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53160|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53168&action=edit [SIGNED-OFF]Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t By properly defining a opachtdocs (intranethtdocs was done too) in the mock function, uninitialized variable warnings are eliminated. Given that we can check if $KOHA_CONF is defined or not, we can catch the warning as part of testing, so the output of the test is cleaner. TEST PLAN --------- 1) unset KOHA_CONF 2) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- lots of noise 3) apply patch 4) prove t/db_dependent/SuggestionEngine_ExplodedTerms.t -- no noise 5) prove -v t/db_dependent/SuggestionEngine_ExplodedTerms.t -- see the warnings were caught and not just ignored. 6) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> No warnings. Works as advertised -- You are receiving this mail because: You are watching all bug changes.