http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 --- Comment #93 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- (In reply to comment #90)
This patch is in conflict with Bug 5347, It seems, few changements can fix it:
In C4::Letters::SendAlerts: Error SQL : DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 7 at /.../C4/Letters.pm line 329.
The query if $type eq 'claimacquisition' become: "SELECT [...] WHERE aqorders.ordernumber IN (;"
I did not get that error. It looks to me as if $externalid array may be corrupt. SendAlerts() does not sanitise input (which is fair enough I suppose). Can you please provide parameters to SendAlerts() that cause the error?
And I need an error if bookseller have no email (for display): unless (@email) { warn "Bookseller $dataorders->[0]->{booksellerid} without emails"; return; }
In my patch, I returned: return {error => "no_email" };
That is fine however then the whole interface needs to change, not only one return value, so I suggest we leave it like it is for the moment. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.