https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lari Taskula from comment #4)
Just curious, how would you represent the answer to availability (what would these return)? Initially I was considering the same solution, but the complexity of availability eventually made me think of putting them it into own classes.
I think that all types of availability answers should always be represented the same, uniform way. It could be a HASHref like in CanBookBeIssued, but I would prefer an object that contains the availability information (Koha::Availability in my proposal) but doesn't define and care about the type of availability; it exists to ensure that we always have the same operations on availability information (to contain yes/maybe/no value to availability, to contain and return additional notes, reasons to ask for confirmation and unavailabilities).
Since you spent more time on this already, it might well be that I would also arrive at some unified structure for these responses :) Koha::Availability just seems (at 'first' glance) to be a too prominent place for such a structure (imho). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.