https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16636 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Florent Mara from comment #4)
I followed the test plan and got the following.
Before applying the patch, prove t/00-load.t would output the following t/00-load.t .. 1/? Too late to run INIT block at /var/koha/Koha/C4/Barcodes/hbyymmincr.pm line 41. Too late to run INIT block at /var/koha/Koha/C4/External/BakerTaylor.pm line 42.
After applying the patch, it would still output 1 warning while the comment appears to indicate there should be no warnings. t/00-load.t .. 7/? Too late to run INIT block at /var/koha/Koha/C4/Barcodes/hbyymmincr.pm line 41. t/00-load.t .. ok All tests successful.
Since the patch focuses on warning from BakerTaylor.pm, I assume it achieves its goal, maybe then the test plan needs to be updated.
Yes, the test plan was a cut-and-paste mistake by me. It should be TEST PLAN --------- 1) prove t/00-load.t -- warnings about INIT for BakerTaylor 2) prove `git grep -l BakerTaylor | grep [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.