https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 --- Comment #33 from Andrew Nugged <nugged@gmail.com> ---
4. (not blocker) Not a bit deal but in tests you can use $builder->build_object instead of ->build, to return a Koha::Object-based object.
and, as I figured out too, seems tests needed to protect numerical zero in rule value not to be overlapped with default: 10) But in case if matching rule has zero ("0") as a value - that allows to have no-fee smart-rule results, as a feature. ... and this is not covered by tests now. So, Petro, you can update tests also taking into account this JD's p4 advice. As well as I see roll-back for this https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123328&action=diff#a/Koha/Hold.pm_sec1 needed to restore this "no-fee (0) for particular items when the default is not zero" feature. -- You are receiving this mail because: You are watching all bug changes.