https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #27)
(In reply to Jonathan Druart from comment #25)
(In reply to Jonathan Druart from comment #24)
2. Why don't we add an option to the script, like the other flags? I would have expected a default number of days picked from the pref, and a flag passed to the script.
ok, I read the previous comments now. But... isn't how the whole script work for the other flags so far?
for instance: 190 $pDebarments = DEFAULT_DEBARMENTS_PURGEDAYS if defined($pDebarments) && $pDebarments == 0;
This is what I was asked to implement, so I did. Koha is on a trajectory of moving away from cli paramters for cronjobs to sysprefs so that librarians can control how cronjobs behave without the need to have a sysadmin make changes for them. I fully expect over time all the parameters for this script will be moved to sysprefs. This is just the first step.
Hi, when I commented on wanting this to be a pref, I was thinking of making it work like the PurgeSuggestionsOlderThan preference. In this case a comment line switch is there, but the number of days and activation for the instance is handled by the pref. I like this solution best, because: - As an admin, you can turn off all deletions easily by removing the switch from the cron, without every library having to change their configuration. This might be handy sometimes (think COVID...) - The libraries have the ability to turn the feature off indidvidually by leaving it empty and set it to the desirable number of days if they want deletions. I think this speaks against a default value of days and I expect that there is not a common default value anyway that would make sense to most libraries. -- You are receiving this mail because: You are watching all bug changes.