https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28050 Bug ID: 28050 Summary: SIP doesn't handle incorrect locations in CP field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In AddReturn we check that the branch for a return exists and force to the userenv if it does not. In SIP we accept the incoming field from CP in a 93 message with no checking. This can create a strange situation where holds are marked as 'In transit' To recreate: 1 - Place a hold for a patron on an item in your catalog 2 - Use the sip cli emulator with a bad location code to check in that item perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CLP -m checkin --item TESTER 3 - Note the typoed 'CLP' instead of 'CPL' 4 - Check the hold in the staff client - it is in transit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.